Conversation
samuelmaddock
approved these changes
Jun 19, 2025
Member
samuelmaddock
left a comment
samuelmaddock
left a comment
There was a problem hiding this comment.
Minor feedback, but overall looks great!
dsanders11
previously requested changes
Jun 19, 2025
hitarth-gg
force-pushed
the
feat/migrate-to-typescript
branch
from
09571c4 to
009d412
Compare
yangannyx
reviewed
Jun 23, 2025
| @@ -0,0 +1,17 @@ | |||
| { | |||
| "compilerOptions": { | |||
Member
There was a problem hiding this comment.
We should add "extends": "@tsconfig/node22/tsconfig.json", to stay consistent with tsconfig standards being set by the Node 22 migration
Member
There was a problem hiding this comment.
Also, not sure if we should remove "target": "es2020", and inherit the target value from the node22 tsconfig.json defaults (es2022) cc @dsanders11
Collaborator
Author
There was a problem hiding this comment.
Ended up removing "target": "es2020", for now, so that it can be inherited from @tsconfig/node22 - 3559fb0
yangannyx
reviewed
Jun 23, 2025
package.json
Outdated
| "autoprefixer": "^10.4.21", | ||
| "babel-loader": "^10.0.0", | ||
| "@types/chrome": "^0.0.326", | ||
| "@types/node": "^24.0.1", |
erickzhao
approved these changes
Jun 25, 2025
yangannyx
approved these changes
Jun 26, 2025
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the initial prototype (#265) to TypeScript.
ts-loaderin the Webpack configuration.